Remove the return_nulls kwarg #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR simplifies the fetchdictarray API by removing the redundant return_nulls boolean parameter. Instead, the presence or absence of null columns is now controlled by whether null_suffix is set to None (to exclude null columns) or a string value (to include them). The default behavior changes from excluding null columns to also excluding them, but through a simpler interface.
Key changes:
- Removed the
return_nullsparameter from the function signature and implementation - Changed the default value of
null_suffixfrom"_isnull"toNonein the C++ code - Updated the docstring to reflect the new API and improved documentation formatting
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
peytondmurray
force-pushed
the
39-remove-return-nulls-kwarg
branch
from
380eb98 to
dbccc81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
return_nullskwarg fromfetchdictarray, and changes the default argument ofnull_suffixtoNone. The docstring has been updated accordingly.No functionality is lost by this change because the boolean
return_nullssimply enabled or disabled null-column inclusion, which is now indicated by passingnull_suffix=None.Closes #39.